feat: Add support for plugins. #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the failing test suite seems to fail generally. |
keelerm84
approved these changes
Jun 25, 2025
| @@ -285,6 +288,7 @@ def __init__( | |||
| self.__big_segments = BigSegmentsConfig() if not big_segments else big_segments | |||
| self.__application = validate_application_info(application or {}, log) | |||
| self.__hooks = [hook for hook in hooks if isinstance(hook, Hook)] if hooks else [] | |||
| self.__plugins = [plugin for plugin in plugins if isinstance(plugin, Plugin)] if plugins else [] | |||
There was a problem hiding this comment.
This line reads like a joke. Peak python! lol
Co-authored-by: Matthew M. Keeler <[email protected]>
keelerm84
approved these changes
Jun 26, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Jul 14, 2025
🤖 I have created a release *beep* *boop* --- ## [9.12.0](9.11.1...9.12.0) (2025-07-11) ### ⚠ BREAKING CHANGES * Drop support for Python 3.8 (eol 2024-10-07) ([#339](#339)) ### Features * Add support for plugins. ([#337](#337)) ([241f6f4](241f6f4)) * Drop support for Python 3.8 (eol 2024-10-07) ([#339](#339)) ([0207665](0207665)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.