Skip to content

Fix: Move argument to method call #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

Fix: Move argument to method call #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LaunchDarkly/GuzzleFeatureRequester.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function __construct($baseUri, $sdkKey, $options)
$this->_logger = $options['logger'];
$stack = HandlerStack::create();
if (class_exists('Kevinrob\GuzzleCache\CacheMiddleware')) {
$stack->push(new CacheMiddleware(new PublicCacheStrategy(isset($options['cache']) ? $options['cache'] : null), 'cache'));
$stack->push(new CacheMiddleware(new PublicCacheStrategy(isset($options['cache']) ? $options['cache'] : null)), 'cache');
Copy link
Contributor Author

@localheinz localheinz May 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'cache' value should probably be an argument to HandlerStack::push($middleware, $name) instead of to the constructor of CacheMiddleware, which only accepts a single argument.

That is, as of the moment, the 'cache' value is currently not used.

} elseif (!$this->_loggedCacheNotice) {
$this->_logger->info("GuzzleFeatureRequester is not using an HTTP cache because Kevinrob\GuzzleCache\CacheMiddleware was not installed");
$this->_loggedCacheNotice = true;
Expand Down