Fix PHP 5.3 incompatibilities #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 22, 2016 10:59
drichelson
commented
Nov 22, 2016
| machine: | ||
| php: | ||
| version: 5.4.37 | ||
| version: 5.3.25 |
There was a problem hiding this comment.
This is the latest php version that CircleCI gives us.
drichelson
commented
Nov 22, 2016
| test: | ||
| override: | ||
| # syntax check php files | ||
| - find ./src -name "*.php" -type f -print0 | xargs -0 -I {} php -l {} |
There was a problem hiding this comment.
'compile' step to ensure php 5.3 compatibility in case tests don't have 100% code coverage
drichelson
commented
Nov 22, 2016
| "guzzle/guzzle": "dev-master#ecb935d2d0ecd8cddae4dcfb90515cac5e2cb023", | ||
| "psr/log": "1.0.0" | ||
| "psr/log": "1.0.0", | ||
| "justinrainbow/json-schema": "v1.6.0" |
There was a problem hiding this comment.
This is a transitive dependency, but the version is not pinned, and by default composer will bring in a version that is too high to be compatible with 5.3.25. This is the highest version compatible with 5.3.25
drichelson
commented
Nov 22, 2016
| private $_negate = false; | ||
|
|
||
| private function __construct($attribute, $op, array $values, $negate) { | ||
| public function __construct($attribute, $op, array $values, $negate) { |
There was a problem hiding this comment.
All these newly public methods are to make the syntax checker happy.
|
👍 |
eli-darkly
added a commit
that referenced
this pull request
Apr 26, 2019
add param to skip db tests, update docs for new repo name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now working with PHP 5.3.25