Make Guzzle 5 a suggestion not a requirement #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| "php": ">=5.4", | ||
| "guzzlehttp/guzzle": "5.*", | ||
| "guzzlehttp/cache-subscriber": "0.1.*" | ||
| "php": ">=5.4" |
There was a problem hiding this comment.
CI tests are failing-- it looks like the dependency changes require PHP 5.5.
|
Thanks for the contribution! Would be happy to merge this in once the CI tests pass. |
|
Will take a look, not sure why moving the deps without changing the version constraints would have caused that. By the way php 5.4 was end of life a while ago, 5.5 will be in 22 days |
|
Thanks-- no issues at all with bumping the requirements up to 5.5. |
|
@jkodumal I've updated the php requirement, the version of PHP that circle ci uses and fixed the version one of the dev dependencies being pulled in as the latest version needed php >=5.6 |
|
Sorry for the delay @richardmiller ! |
eli-darkly
added a commit
that referenced
this pull request
Aug 25, 2018
add new version of allFlags() that captures more metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR to make Guzzle 5 a suggestion rather than a requirement. Intending to follow up with a Guzzle 6 compatible implementation of the Feature Requester.