Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

strategy:
matrix:
php-version: [8.1.26, 8.2.13]
php-version: ['8.1', '8.2']

env:
LD_INCLUDE_INTEGRATION_TESTS: 1
Expand All @@ -54,15 +54,14 @@ jobs:
with:
fetch-depth: 0 # If you only need the current version keep this.

- name: Setup PHP
uses: shivammathur/setup-php@e6f75134d35752277f093989e72e140eaa222f35
with:
php-version: ${{ matrix.php-version }}

- name: Install java support
run: choco install -y javaruntime

- name: Install php support
run: choco install -y php --version=${{ matrix.php-version }} --force

- name: Install composer
run: choco install -y composer

- name: Download wiremock
run: Invoke-WebRequest -Uri https://repo1.maven.org/maven2/com/github/tomakehurst/wiremock-jre8-standalone/2.31.0/wiremock-jre8-standalone-2.31.0.jar -UseBasicParsing -OutFile wiremock.jar

Expand Down
2 changes: 1 addition & 1 deletion src/LaunchDarkly/Migrations/OpTracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public function build(): array|string
$event = [
'kind' => 'migration_op',
'creationDate' => Util::currentTimeUnixMillis(),
'contextKeys' => $this->context->getKeys(),
'context' => $this->context,
'operation' => $this->operation->value,
'evaluation' => [
'key' => $this->key,
Expand Down
2 changes: 1 addition & 1 deletion test-service/TestService.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function getStatus(): array
'secure-mode-hash',
'migrations',
'event-sampling',
'inline-context',
'inline-context-all',
'anonymous-redaction',
'client-prereq-events',
'big-segments'
Expand Down
2 changes: 1 addition & 1 deletion tests/Migrations/OpTrackerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function testCanBuildSuccessfully(): void
$this->assertIsArray($result, 'tracker failed to build event');
$this->assertEquals('migration_op', $result['kind']);
$this->assertEquals('read', $result['operation']);
$this->assertSame(['user' => 'user-key'], $result['contextKeys']);
$this->assertEquals(LDContext::create('user-key'), $result['context']);

$evaluation = $result['evaluation'];
$this->assertEquals('flag', $evaluation['key']);
Expand Down