Skip to content

Conversation

@mrtus
Copy link
Contributor

@mrtus mrtus commented Dec 31, 2019

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Describe the solution you've provided

Allow monolog/monolog:^2.0 to be required as dependency next to its monolog/monolog:^1.6 version.

Additional context

As a developer I want the latest Monolog dependency to be installed in projects where I use launchdarkly/php-server-sdk.

@mrtus mrtus marked this pull request as ready for review December 31, 2019 13:16
@eli-darkly
Copy link
Contributor

Thanks. This seems to cover all current use cases, and I believe it solves the immediate concern raised in #129.

@eli-darkly eli-darkly merged commit 953fcdd into launchdarkly:master Jan 1, 2020
@eli-darkly
Copy link
Contributor

This change is included in the 3.7.1 release.

@mrtus
Copy link
Contributor Author

mrtus commented Jan 4, 2020

Thank you for the quick merge and version bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants