prepare 3.4.1 release

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly PHP SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [3.4.1] - 2018-09-25
+### Fixed:
+- Improved the performance of `allFlags`/`allFlagsState` by not making redundant individual requests for prerequisite flags, when a flag is being evaluated that has prerequisites. Instead it will reuse the same flag data that it already obtained from LaunchDarkly in the "get all the flags" request.
+
 ## [3.4.0] - 2018-09-04
 ### Added:
 - The new `LDClient` method `variationDetail` allows you to evaluate a feature flag (using the same parameters as you would for `variation`) and receive more information about how the value was calculated. This information is returned in an object that contains both the result value and a "reason" object which will tell you, for instance, if the user was individually targeted for the flag or was matched by one of the flag's rules, or if the flag returned the default value due to an error.

VERSION

@@ -1 +1 @@
-3.4.0
+3.4.1

src/LaunchDarkly/LDClient.php

@@ -12,7 +12,7 @@ class LDClient
 {
     const DEFAULT_BASE_URI = 'https://app.launchdarkly.com';
     const DEFAULT_EVENTS_URI = 'https://events.launchdarkly.com';
-    const VERSION = '3.4.0';
+    const VERSION = '3.4.1';
 
     /** @var string */
     protected $_sdkKey;
@@ -350,14 +350,17 @@ public function allFlagsState($user, $options = array())
             return new FeatureFlagsState(false);
         }
 
+        $preloadedRequester = new PreloadedFeatureRequester($this->_featureRequester, $flags);
+        // This saves us from doing repeated queries for prerequisite flags during evaluation
+
         $state = new FeatureFlagsState(true);
         $clientOnly = isset($options['clientSideOnly']) && $options['clientSideOnly'];
         $withReasons = isset($options['withReasons']) && $options['withReasons'];
         foreach ($flags as $key => $flag) {
             if ($clientOnly && !$flag->isClientSide()) {
                 continue;
             }
-            $result = $flag->evaluate($user, $this->_featureRequester);
+            $result = $flag->evaluate($user, $preloadedRequester);
             $state->addFlag($flag, $result->getDetail(), $withReasons);
         }
         return $state;

src/LaunchDarkly/PreloadedFeatureRequester.php

@@ -0,0 +1,52 @@
+<?php
+namespace LaunchDarkly;
+
+class PreloadedFeatureRequester implements FeatureRequester
+{
+    /** @var FeatureRequester */
+    private $_baseRequester;
+
+    /** @var array */
+    private $_knownFeatures;
+
+    public function __construct($baseRequester, $knownFeatures)
+    {
+        $this->_baseRequester = $baseRequester;
+        $this->_knownFeatures = $knownFeatures;
+    }
+
+    /**
+     * Gets feature data from cached values
+     *
+     * @param $key string feature key
+     * @return FeatureFlag|null The decoded FeatureFlag, or null if missing
+     */
+    public function getFeature($key)
+    {
+        if (isset($this->_knownFeatures[$key])) {
+            return $this->_knownFeatures[$key];
+        }
+        return null;
+    }
+
+    /**
+     * Gets segment data from the regular feature requester
+     *
+     * @param $key string segment key
+     * @return Segment|null The decoded Segment, or null if missing
+     */
+    public function getSegment($key)
+    {
+        return $this->_baseRequester->getSegment($key);
+    }
+
+    /**
+     * Gets all features from cached values
+     *
+     * @return array()|null The decoded FeatureFlags, or null if missing
+     */
+    public function getAllFeatures()
+    {
+        return $this->_knownFeatures;
+    }
+}