Fix test confirming send_events = false is honored (#78)

Author: keelerm84

tests/LDClientTest.php

@@ -3,15 +3,11 @@
 
 use InvalidArgumentException;
 use LaunchDarkly\EvaluationReason;
-use LaunchDarkly\FeatureRequester;
 use LaunchDarkly\LDClient;
 use LaunchDarkly\LDUser;
 use LaunchDarkly\LDUserBuilder;
-use LaunchDarkly\Impl\Events\EventFactory;
-use LaunchDarkly\Impl\Events\EventProcessor;
 use LaunchDarkly\Impl\Model\FeatureFlag;
 use Psr\Log\LoggerInterface;
-use PHPUnit\Framework\TestCase;
 
 class LDClientTest extends \PHPUnit\Framework\TestCase
 {
@@ -64,7 +60,7 @@ private function makeClient($overrideOptions = array())
         );
         return new LDClient("someKey", array_merge($options, $overrideOptions));
     }
-    
+
     public function testVariationReturnsFlagValue()
     {
         $flag = $this->makeOffFlagWithValue('feature', 'value');
@@ -362,7 +358,7 @@ public function testAllFlagsStateReturnsState()
         $builder = new LDUserBuilder(3);
         $user = $builder->build();
         $state = $client->allFlagsState($user);
-         
+
         $this->assertTrue($state->isValid());
         $this->assertEquals(array('feature' => 'off'), $state->toValuesMap());
         $expectedState = array(
@@ -405,7 +401,7 @@ public function testAllFlagsStateReturnsStateWithReasons()
         $builder = new LDUserBuilder(3);
         $user = $builder->build();
         $state = $client->allFlagsState($user, array('withReasons' => true));
-         
+
         $this->assertTrue($state->isValid());
         $this->assertEquals(array('feature' => 'off'), $state->toValuesMap());
         $expectedState = array(
@@ -447,7 +443,7 @@ public function testAllFlagsStateCanFilterForClientSideFlags()
         $builder = new LDUserBuilder(3);
         $user = $builder->build();
         $state = $client->allFlagsState($user, array('clientSideOnly' => true));
-         
+
         $this->assertTrue($state->isValid());
         $this->assertEquals(array('client-side-1' => 'value1', 'client-side-2' => 'value2'), $state->toValuesMap());
     }
@@ -507,7 +503,7 @@ public function testAllFlagsStateCanOmitDetailsForUntrackedFlags()
         $builder = new LDUserBuilder(3);
         $user = $builder->build();
         $state = $client->allFlagsState($user, array('withReasons' => true, 'detailsOnlyForTrackedFlags' => true));
-         
+
         $this->assertTrue($state->isValid());
         $this->assertEquals(array('flag1' => 'value1', 'flag2' => 'value2', 'flag3' => 'value3'), $state->toValuesMap());
         $expectedState = array(
@@ -610,7 +606,7 @@ public function testAliasEventsAreCorrect()
     {
         $ep = new MockEventProcessor();
         $client = $this->makeClient(array('event_processor' => $ep));
-        
+
         $user_builder = new LDUserBuilder("[email protected]");
         $user = $user_builder->anonymous(false)->build();
         $anon_builder = new LDUserBuilder("[email protected]");
@@ -639,16 +635,21 @@ public function testEventsAreNotPublishedIfSendEventsIsFalse()
         $mockPublisher = new MockEventPublisher("", array());
         $options = array(
             'feature_requester_class' => MockFeatureRequester::class,
-            'event_publisher' => $mockPublisher
+            'event_publisher' => $mockPublisher,
+            'send_events' => false,
         );
         $client = new LDClient("someKey", $options);
         $client->track('eventkey', new LDUser('userkey'));
+
+        // We don't flush the event processor until __destruct is called. Let's
+        // force that by unsetting this variable.
+        unset($client);
         $this->assertEquals(array(), $mockPublisher->payloads);
     }
 
     public function testOnlyValidFeatureRequester()
     {
-        $this->expectException(\InvalidArgumentException::class);
+        $this->expectException(InvalidArgumentException::class);
         new LDClient("BOGUS_SDK_KEY", ['feature_requester_class' => \stdClass::class]);
     }
 
@@ -658,29 +659,29 @@ public function testSecureModeHash()
         $user = new LDUser("Message");
         $this->assertEquals("aa747c502a898200f9e4fa21bac68136f886a0e27aec70ba06daf2e2a5cb5597", $client->secureModeHash($user));
     }
-    
+
     public function testLoggerInterfaceWarn()
     {
         // Use LoggerInterface impl, instead of concreate Logger from Monolog, to demonstrate the problem with `warn`.
         $logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
-        
+
         $logger->expects(self::atLeastOnce())->method('warning');
-        
+
         $client = new LDClient('secret', [
             'logger' => $logger,
         ]);
-    
+
         $user = new LDUser('');
-        
+
         $client->variation('MyFeature', $user);
     }
-    
+
     private function getPrivateField(&$object, $fieldName)
     {
         $reflection = new \ReflectionClass(get_class($object));
         $field = $reflection->getProperty($fieldName);
         $field->setAccessible(true);
-    
+
         return $field->getValue($object);
     }
 }