Merge pull request #75 from launchdarkly/eb/sc-126500/rm-obsolete-line

eli-darkly · web-flow · commit 77b990e473f4 · 2021-10-13T09:23:46.000-07:00
remove obsolete line that's no longer used because $seed is computed elsewhere
diff --git a/src/LaunchDarkly/Impl/Model/FeatureFlag.php b/src/LaunchDarkly/Impl/Model/FeatureFlag.php
@@ -220,7 +220,6 @@ private function getOffValue(EvaluationReason $reason): EvaluationDetail
     private function getValueForVariationOrRollout(VariationOrRollout $r, LDUser $user, EvaluationReason $reason): EvaluationDetail
     {
         $rollout = $r->getRollout();
-        $seed = is_null($rollout) ? null : $rollout->getSeed();
         list($index, $inExperiment) = $r->variationIndexForUser($user, $this->_key, $this->_salt);
         if ($index === null) {
             return new EvaluationDetail(null, null, EvaluationReason::error(EvaluationReason::MALFORMED_FLAG_ERROR));

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,6 @@ private function getOffValue(EvaluationReason $reason): EvaluationDetail`
`220`	`220`	`private function getValueForVariationOrRollout(VariationOrRollout $r, LDUser $user, EvaluationReason $reason): EvaluationDetail`
`221`	`221`	`{`
`222`	`222`	`$rollout = $r->getRollout();`
`223`		`- $seed = is_null($rollout) ? null : $rollout->getSeed();`
`224`	`223`	`list($index, $inExperiment) = $r->variationIndexForUser($user, $this->_key, $this->_salt);`
`225`	`224`	`if ($index === null) {`
`226`	`225`	`return new EvaluationDetail(null, null, EvaluationReason::error(EvaluationReason::MALFORMED_FLAG_ERROR));`