add unit test for passing a preconfigured client #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-darkly
commented
Jul 31, 2021
| $factory = Redis::featureRequester(); | ||
| return $factory('', '', ['redis_prefix' => $prefix]); | ||
| $factory = Redis::featureRequester(['redis_prefix' => $prefix]); | ||
| return $factory('', '', []); |
Contributor
Author
There was a problem hiding this comment.
This change just makes it so we are using the preferred way of configuring the Redis integration, where you put the Redis-specific options in the call to featureRequester. The other way, where those options are mixed in with the rest of the SDK options (the 3rd parameter in the call to $factory would be the SDK options), is deprecated.
zurab-darkly
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for the same kind of behavior mentioned in launchdarkly/php-server-sdk#151; even though that PR is for the phpredis integration, not the Predis one, both have a similar "use an existing client" option. We've already added an equivalent test in PHP SDK 3.x where the database integrations are still in the main SDK package, so this is the version for the separate package for use with PHP SDK 4.x.