-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Add dynamodb_client as new option
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dynamodb_client as new option
#20
Conversation
keelerm84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor point to discuss.
src/LaunchDarkly/Impl/Integrations/DynamoDbFeatureRequester.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew M. Keeler <[email protected]>
|
Thank you so much for your contribution and patience as we worked through getting this merged. |
|
My pleasure @keelerm84! one last question… will there be a new tag so everyone can download this new feat as part of 1.X? |
|
Oh, sorry. Just seen this is being part of the release: #21 Thank you so much @keelerm84! |
🤖 I have created a release *beep* *boop* --- ## [1.3.0](1.2.0...1.3.0) (2024-07-31) ### Features * Support using fully configured DynamoDbClient via new `dynamodb_client` option ([#20](#20)) ([ccb1380](ccb1380)) ### Miscellaneous Chores * Add test covering direct DynamoDbClient injection ([#22](#22)) ([4f43ee8](4f43ee8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Sorry for the delay there. This has been released now as v1.3.0 Thanks again! |
Follow up of: #19 (Closed)
Summary
This PR introduces a new option
dynamodb_clientto theDynamoDbintegration, allowing developers to reuse an existingDynamoDbClientinstance. This enhancement provides more flexibility and control over the DynamoDB client configuration.Changes
New Option Added:
dynamodb_client: Allows passing an already-configuredDynamoDbClientinstance. If specified, this will cause all other options exceptdynamodb_prefixanddynamodb_tableto be ignored.Updated
DynamoDbFeatureRequesterConstructor:dynamodb_clientoption and use it if provided.Documentation:
DynamoDbto reflect the new option and provide usage examples.Usage
Developers can now configure the
feature_requesterwith an existingDynamoDbClientinstance as shown below: