This repository was archived by the owner on May 30, 2024. It is now read-only.
Add typescript definitions #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| /** | ||
| * The LaunchDarkly static global. | ||
| */ | ||
| export function init(key: string, user: LDUser, options?: LDOptions): LDClient; |
There was a problem hiding this comment.
Is the user: LDUser param meant to be here?
It doesn't seem to align with new_client fn (exported as init): https://github.com/launchdarkly/node-client/blob/142a7dd1d78bf10c31d7df1f7fb454ff19664b3c/index.js#L19
There was a problem hiding this comment.
Great catch, that definitely shouldn't be there.
Will patch in a few, thanks @natebrennand
Closed
eli-darkly
added a commit
that referenced
this pull request
Mar 14, 2018
fix optimistic locking logic to retry updates as needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typescript definitions to this npm module.
From now on, any changes to the client API should also be reflected in the typescript definitions.