fix: correcting protocol parsing logic that may lead to incorrect sanitization of an incoming message from LD servers #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itization of an incoming message from LD servers
keelerm84
approved these changes
Jan 21, 2025
tanderson-ld
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [5.6.1](5.6.0...5.6.1) (2025-01-21) ### Bug Fixes * correcting protocol parsing logic that may lead to incorrect sanitization of an incoming message from LD servers ([#288](#288)) ([9969148](9969148)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After examining related code to a customer support case and #278, noticed this modification during iteration. Theoretical issue is that modification during iteration, even if not resulting in ConcurrentModificationExceptions, could result in unpredictable iteration and could possibly skip sanitizing certain incoming flags.
Through bench testing and instrumentation testing, I was unable to reproduce the issue, but I suspect it may be dependent on the specific platform's implementation of the Map type that GSON will depend on. Will deploy this fix and work with customers to confirm if the occurrences of the issue is eliminated.