[sqlx-cli] potential issue in workspace crates

[mehcode]

#249 (comment)

cc @phated

[jgrund]

I'm hitting this as well. It appears to come from this block:

sqlx/sqlx-cli/src/prepare.rs

Lines 78 to 94 in e3b3806

	let check_status = Command::new(&cargo)
	.arg("rustc")
	.args(cargo_args)
	.arg("--")
	.arg("--emit")
	.arg("dep-info,metadata")
	// set an always-changing cfg so we can consistently trigger recompile
	.arg("--cfg")
	.arg(format!(
	"__sqlx_recompile_trigger=\"{}\"",
	SystemTime::UNIX_EPOCH.elapsed()?.as_millis()
	))
	.status()?;
	if !check_status.success() {
	bail!("`cargo check` failed with status: {}", check_status);
	}

If I comment that out the generation proceeds forward.

[jgrund]

Just running cargo rustc yields:

manifest path `/Users/jgrund/repos/whamcloud/integrated-manager-for-lustre/Cargo.toml` is a virtual manifest, but this command requires running against an actual package in this workspace

[jgrund]

Since the intent of this code is to ensure a recompile occurs, I'm using this as a workaround for now:

    let check_status = Command::new(&cargo).arg("clean").status()?;

    if !check_status.success() {
        bail!("`cargo clean` failed with status: {}", check_status);
    }

    let check_status = Command::new(&cargo)
        .arg("check")
        .args(cargo_args)
        .status()?;

    if !check_status.success() {
        bail!("`cargo check` failed with status: {}", check_status);
    }

while it forces a full recompile, it also works using workspaces.

[jgrund]

Another issue I'm hitting is CARGO_MANIFEST_DIR doesn't appear to consistently point at the workspace root.

The variable is used to find the sqlx-data.json file here:

sqlx/sqlx-macros/src/query/mod.rs

Lines 26 to 54 in c327e63

	let manifest_dir =
	env::var("CARGO_MANIFEST_DIR").map_err(|_| "`CARGO_MANIFEST_DIR` must be set")?;
	// If a .env file exists at CARGO_MANIFEST_DIR, load environment variables from this,
	// otherwise fallback to default dotenv behaviour.
	let env_path = std::path::Path::new(&manifest_dir).join(".env");
	if env_path.exists() {
	dotenv::from_path(&env_path)
	.map_err(|e| format!("failed to load environment from {:?}, {}", env_path, e))?
	}
	// if `dotenv` wasn't initialized by the above we make sure to do it here
	match dotenv::var("DATABASE_URL").ok() {
	Some(db_url) => expand_from_db(input, &db_url),
	#[cfg(feature = "offline")]
	None => {
	let data_file_path = std::path::Path::new(&manifest_dir).join("sqlx-data.json");
	if data_file_path.exists() {
	expand_from_file(input, data_file_path)
	} else {
	Err(
	"`DATABASE_URL` must be set, or `cargo sqlx prepare` must have been run \
	and sqlx-data.json must exist, to use query macros"
	.into(),
	)
	}
	}

It appears to resolve correctly with cargo check, but not with cargo test.