mongodb v5 fixes #13
Open
mongodb v5 fixes #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using delete promise instead of removed callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bsonpackage has removed ObjectID (with capitalD) from v5 on, which can be seen in the release notes. As mongodb v5.0.0 adopted all changes from bson v5.0.0 and this plugin depends on mongodb v5.4.0 this plugin should useObjectIdinstead ofObjectID.Furthermore did mongodb v5 remove certain callback signatures in favor of promises including the one for delete.
This PR should fix those issues.