Made all I/O functions/methods to accept either a string or a pathlib.Path object for any path argument (issue 896) #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdementen
approved these changes
Sep 28, 2021
Contributor
gdementen
left a comment
gdementen
left a comment
There was a problem hiding this comment.
except from the (AFAICT) broken "None" case above, this LGTM
larray/inout/common.py
Outdated
| """ | ||
| def __init__(self, fname, overwrite_file=False): | ||
| self.fname = fname | ||
| self.fname = Path(fname) |
Contributor
There was a problem hiding this comment.
only convert to Path if not isinstance(fname, Path)?
Collaborator
Author
|
Could you review the last commit before I rebase on upstream/master ? |
gdementen
approved these changes
Sep 29, 2021
Contributor
gdementen
left a comment
gdementen
left a comment
There was a problem hiding this comment.
I don't think asking for review again for something already reviewed once is worth our time (except for very tricky/large PR). Yes, I nearly always find something to improve but it's really details and I don't think it's worth our time
…l i/o functions/methods/classes
alixdamman
force-pushed
the
896_pathlib
branch
from
45ad517 to
2bc1f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.