Rename replace_axes as set_axes + update doc of rename method #147
Conversation
gdementen
left a comment
gdementen
left a comment
There was a problem hiding this comment.
the release notes in the other PR will need to be updated too
larray/core.py
Outdated
| BE | 0 | 1 | ||
| FO | 2 | 3 | ||
| >>> arr.rename({'nat': 'nat2', 'sex': 'sex2'}) | ||
| nat2\\sex2 | M | F |
There was a problem hiding this comment.
duh? this is the same as the previous example?
There was a problem hiding this comment.
It was to test the inplace flag. I failded to properly clean the examples.
| "data shape %s" % (axes.shape, data.shape)) | ||
|
|
||
| # Because __getattr__ and __setattr__ have been rewritten | ||
| # Because __getattr__ and __setattr__ have been overridden |
There was a problem hiding this comment.
even though it is indeed the case, __setattr__ should actually not be overridden (ever since we changed __getattr__ to return axes). It might be better to fix that in a separate PR though, because most (all?) object.__setattr__ could/should be replaced.
larray/core.py
Outdated
| >>> column = Axis('column', ['c0', 'c1', 'c2']) | ||
| >>> arr.replace_axes(x.a, row) | ||
| Replace one axis (expect 2 arguments) |
There was a problem hiding this comment.
the "expect 2 arguments" part is a bit strange. who should expect? the function or the user? => replace by somethng like:
Replace one axis (the second argument is required when using this syntax)
fix larray-project#133 :Rename replace_axes as set_axes. Add inplace flag to set_axes and rename methods
alixdamman
force-pushed
the
rename_replace_axes
branch
from
a0bd8c8 to
a139f99
Compare
|
LGTM |
2 participants
fix #121 : Update docstring of set_labels.
fix #133 : Rename replace_axes as set_axes.
Add inplace flag to set_axes and rename methods