fix #43 (autoresize) #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) and resizeAxesRowToContents() methods + synchronized view_axes with view_x/ylabels in ArrayEditorWidget
gdementen
reviewed
Sep 27, 2017
larray_editor/arraywidget.py
Outdated
| # no need to call resizeSection on view_ylabels (see synchronization lines in init) | ||
| self.view_axes.horizontalHeader().resizeSection(column, width) | ||
|
|
||
| def resizeDataColumnToContents(self, column): |
There was a problem hiding this comment.
rename to resize_xlabels_column_to_contents because this works first on the view_xlabels not view_data?
- to be consistent with resizeAxes... which works on view_axes
- to respect python naming conventions (this is not an overridden method name)
larray_editor/arraywidget.py
Outdated
| self.view_xlabels.horizontalHeader().resizeSection(column, width) | ||
|
|
||
| def resizeRowToContents(self, row): | ||
| def resizeAxesRowToContents(self, row): |
There was a problem hiding this comment.
rename to resize_axes_row_to_contents?
larray_editor/arraywidget.py
Outdated
| # no need to call resizeSection on view_xlabels (see synchronization lines in init) | ||
| self.view_axes.verticalHeader().resizeSection(row, height) | ||
|
|
||
| def resizeDataRowToContents(self, row): |
larray_editor/arraywidget.py
Outdated
| self.resizeDataColumnToContents(column) | ||
|
|
||
| def resizeColumnToContents(self, column): | ||
| def resizeAxesColumnToContents(self, column): |
There was a problem hiding this comment.
rename to resize_axes_column_to_contents?
larray_editor/api.py
Outdated
|
|
||
| # test autoresizing | ||
| arr8 = la.zeros('a=a_long_label,another_long_label') | ||
| arr8 = la.zeros('a=a_long_label,another_long_label; b=this_is_a_label,this_is_another_one') |
There was a problem hiding this comment.
it would be nice to give meaningful names to those arrays: either what do they test, or what is their "special" characteristic, eg:
>>> test_column_resize1 = la.zeros('a=a_long_label,another_long_label; b=this_is_a_label,this_is_another_one')
>>> # or
>>> long_labels = la.zeros('a=a_long_label,another_long_label; b=this_is_a_label,this_is_another_one')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.