Skip to content

Conversation

@halaei
Copy link
Contributor

@halaei halaei commented May 15, 2017

The current code does not work if someone deletes the record from DB. It is a security risk I guess.

@taylorotwell
Copy link
Member

This is very hard to read with the negative boolean checks.

@taylorotwell
Copy link
Member

I still have no idea what this is doing. Needs to be re-written.

@halaei
Copy link
Contributor Author

halaei commented May 17, 2017

This also works, but is slightly less efficient:

    public function revoked($id)
    {
        return ! $this->findActive($id);
    }

Will it be fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants