Skip to content

Conversation

@trippo
Copy link
Contributor

@trippo trippo commented Aug 7, 2025

In the upgrade.md guide, there’s an example showing how to set the view prefix using:

// Or using conventional names under the given prefix...
Passport::viewPrefix('auth.oauth');

However, in practice, this does not work as intended unless the prefix includes a trailing dot, like so:

Passport::viewPrefix('auth.oauth.');

To address this inconsistency, this PR updates the viewPrefix method to automatically handle the trailing dot, making it consistent with the documentation. This avoids requiring users to remember to add the dot manually and ensures the example in the upgrade guide works out of the box.

Alternatively, we would have to update the documentation — but this fix ensures a better developer experience.

Copy link
Contributor

@hafezdivandari hafezdivandari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid a breaking change by trimming dot from end of the given prefix.

@taylorotwell taylorotwell merged commit 7e99ca9 into laravel:13.x Aug 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants