[13.x] Fallback to list of auth user providers if no auth guard for Passport is defined #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hafezdivandari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1838
When running the
passport:installcommand, the user is prompted to create a "personal access" grant client. If they respond with "yes", this command attempts to list the user providers from auth guards that use Passport as their driver for user to choose from. However, since Passport hasn't been fully installed at this point, there may be no such guards defined yet, resulting in an empty list and an exception.This PR addresses the issue by falling back to list of all configured auth user providers if no Passport-based auth guards are available.