Skip to content

Conversation

@hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Aug 7, 2024

Fixes #899

As stated on the docs, we skip the auth prompt if the user previously authorized access to the consuming application for the requested scopes. However, the current implementation checks the scopes of the latest valid token only, not all the previously granted scopes.

This PR does:

  • Fix implementation of skipping authorization screen.
  • Pass user and scopes to Client::skipsAuthorization() method.

@hafezdivandari hafezdivandari marked this pull request as ready for review August 7, 2024 14:21
@hafezdivandari hafezdivandari marked this pull request as draft August 7, 2024 14:31
@hafezdivandari hafezdivandari marked this pull request as ready for review August 7, 2024 16:05
@taylorotwell taylorotwell merged commit 61644b3 into laravel:13.x Aug 7, 2024
@hafezdivandari hafezdivandari deleted the 13.x-fix-skip-concent branch August 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants