Skip to content

[9.x] Warn about one-time-hashed-secret #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2020
Merged

[9.x] Warn about one-time-hashed-secret #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7069c66
Warn about one-time-hashed-secret
driesvints May 8, 2020
1e1871c
Update ClientCommand.php
taylorotwell May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Console/ClientCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Illuminate\Console\Command;
use Laravel\Passport\Client;
use Laravel\Passport\ClientRepository;
use Laravel\Passport\Passport;

class ClientCommand extends Command
{
Expand Down Expand Up @@ -161,6 +162,11 @@ protected function createAuthCodeClient(ClientRepository $clients)
*/
protected function outputClientDetails(Client $client)
{
if (Passport::$hashesClientSecrets) {
$this->line('<comment>Here is your new client secret. This is the only time it will be shown so don\'t lose it!</comment>');
$this->line('');
}

$this->line('<comment>Client ID:</comment> '.$client->id);
$this->line('<comment>Client secret:</comment> '.$client->plainSecret);
}
Expand Down