Update PHPDocs for IDE support. #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrected the namespaces.
Contributor
|
Looks like you broke the line endings, though. |
Contributor
|
There's no reason to prefix it with the backslash is there? |
Contributor
|
Jason, that was discussed in another issue. Basically, it's about IDE support. Taylor essentially said something along the lines of he might change them to this "proper" way while changing other things, but I'm sure he's thankful for somebody doing all this work for him. |
Contributor
|
Ah okay then, fair enough! :) |
I'm not done yet. The rest is still coming.
This reverts commit e9c98dc.
Contributor
|
Looks good :) |
Contributor
|
👍 It is really annoying to not have autocompletion. Somehow makes the complete PHPDocs useless. |
joelharkes
pushed a commit
to joelharkes/framework_old
that referenced
this pull request
Mar 7, 2019
…n-endpoints-tests Subscription endpoints tests
gonzalom
pushed a commit
to Hydrane/tmp-laravel-framework
that referenced
this pull request
Oct 12, 2023
Type hint parameter to match the changes in contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected the namespaces.