[12.x] Follow up improvements to #57557 #57587
Closed
+18
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #57557 as discussed in the comments.
Approach does not change compared to 57557. But in 8.4 we get an advantage because:
get_object_vars()call; avoids duplicate work.unset()for each undesired property.array_keys()callMakes it slightly faster (~25%) and a bit cleaner. Nothing massive, but things add up.
Since it's a fresh feature it doesn't hurt to squeeze what we can.
Addtionally: