Fix S3 adapter to use correct path separator and update related tests #57497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


In #55119 it was reported that when using the S3 adapter on Windows and setting a
root, thePathPrefixeruses the OS'sDIRECTORY_SEPARATOR, which on Windows is\\.However, AWS only allows
/as a separator, and most S3 implementations also do.This PR overrides the
PathPrefixerfor the S3 Adapter to always use/.I have added a test to make sure this behavior works, by manually setting the
directory_separatorconfig value in the test. This ensures that/is always used.This should not break anything.
Repost of my last pull requests because unfortunally Laravel Pint or some other IDe tool redid all the naming of the test cases.