Skip to content

Conversation

@ropi-bc
Copy link

@ropi-bc ropi-bc commented Oct 8, 2025

Solves #57305.

The current implementation of Arr::dot() doesn't flatten arrays that contain empty arrays. This goes against my intuition, so I'm proposing a change to reflect what I think should happen instead.

Opened the PR preemptively to:

  • Hopefully speed up the process
  • Serve as a clear description of my expectations

@taylorotwell
Copy link
Member

Won't be changing on a patch release.

@ropi-bc
Copy link
Author

ropi-bc commented Oct 8, 2025

do you want me to revisit this change later, or what does this mean exactly? @taylorotwell

@cosmastech
Copy link
Contributor

do you want me to revisit this change later, or what does this mean exactly? @taylorotwell

Probably means make the branch against master 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants