[12.x] Fix hours and minutes extraction in scheduler dailyAt() method
#56304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic in the
dailyAt()method to correctly handle time strings containing hours, minutes, and seconds (e.g., "10:20:30").Previously, if the
$timestring contained more than two segments, the minutes value would incorrectly default to'0'.By changing the condition from
count($segments) === 2tocount($segments) >= 2, we ensure that the minutes value is preserved even when seconds are present. This does not change the existing behavior; seconds are still ignored exactly as before.count($segments) === 2 || count($segments) === 3, but I think the above method is more performant than using twocount()calls.