Skip to content

[12.x] Add enum support for job method in scheduler #56101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[12.x] Add enum support for job method in scheduler #56101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Illuminate/Console/Scheduling/Schedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
use Illuminate\Support\Traits\Macroable;
use RuntimeException;

use function Illuminate\Support\enum_value;

/**
* @mixin \Illuminate\Console\Scheduling\PendingEventAttributes
*/
Expand Down Expand Up @@ -170,14 +172,17 @@ public function command($command, array $parameters = [])
* Add a new job callback event to the schedule.
*
* @param object|string $job
* @param string|null $queue
* @param string|null $connection
* @param \UnitEnum|string|null $queue
* @param \UnitEnum|string|null $connection
* @return \Illuminate\Console\Scheduling\CallbackEvent
*/
public function job($job, $queue = null, $connection = null)
{
$jobName = $job;

$queue = enum_value($queue);
$connection = enum_value($connection);

if (! is_string($job)) {
$jobName = method_exists($job, 'displayName')
? $job->displayName()
Expand Down