[12.x] Resolve issue with BelongsToManyRelationship factory

[jackbayliss]

When updating to 12.11.0, I noticed a bunch of tests started to fail with :

BadMethodCallException: Call to undefined method Illuminate\Database\Query\Builder::()

This looks to be have been introduced via #55558

This is because :

framework/src/Illuminate/Database/Eloquent/Factories/BelongsToManyRelationship.php

Line 53 in bcc9220

$relationship = $model->{$this->relationship}();

If it's not an instance of Factory, this relationship can be an empty string-- thus causing this to fail as there's no function to call. The $relationship var is only used if it's a factory instance anyway, so this makes sense- I hope!

Here's a failing test as a rough example:

    #[DataProvider('providerExample')]
    public function test_belongs_to_many_relationship_empty_factory(int $relationshipTotal)
    {
        $relation = FactoryTestRoleFactory::times($relationshipTotal)->create();
        
        FactoryTestUserFactory::times(2)
            ->hasAttached($relation)
            ->create();

        $this->assertCount(2, FactoryTestUser::all());
    }

    public static function providerExample()
    {
        return [
            [0], // maybe I want to assert something if there's no relation
            [1],
            [2]
        ];
    }

Cheers 🫡

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.