Skip to content

Conversation

@xiCO2k
Copy link
Member

@xiCO2k xiCO2k commented Feb 20, 2024

This PR makes sure the health endpoint loads even if there is a model binding on the root:

Example

// routes/web.php

use Illuminate\Support\Facades\Route;

Route::get('/{user}', fn () => response('', 404));

before this PR it will load the /{user} route before the health.

@xiCO2k xiCO2k changed the title [11.x] Make sure the health route is loaded. [11.x] Make sure the health route is loaded Feb 20, 2024
@xiCO2k xiCO2k changed the title [11.x] Make sure the health route is loaded [11.x] health route is loaded even if there is a model binding on the root. Feb 20, 2024
@xiCO2k xiCO2k changed the title [11.x] health route is loaded even if there is a model binding on the root. [11.x] health route is loaded even if there is a model binding on the root Feb 20, 2024
@xiCO2k xiCO2k changed the title [11.x] health route is loaded even if there is a model binding on the root [11.x] The health route is loaded even when there is a model binding at the root Feb 20, 2024
@xiCO2k xiCO2k changed the title [11.x] The health route is loaded even when there is a model binding at the root [11.x] The health route should be loaded even when there is a model binding at the root Feb 20, 2024
@taylorotwell taylorotwell merged commit 597f77e into laravel:master Feb 21, 2024
@xiCO2k xiCO2k deleted the fix/health branch February 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants