Skip to content

[10.x] Use container to resolve email validator class #48942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[10.x] Use container to resolve email validator class #48942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8189ba5
Update ValidatesAttributes.php
orkhanahmadov Nov 8, 2023
2abf2cf
Use container to resolve EmailValidator
orkhanahmadov Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Illuminate/Validation/Concerns/ValidatesAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Egulias\EmailValidator\Validation\NoRFCWarningsValidation;
use Egulias\EmailValidator\Validation\RFCValidation;
use Exception;
use Illuminate\Container\Container;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Exceptions\MathException;
Expand Down Expand Up @@ -840,7 +841,9 @@ public function validateEmail($attribute, $value, $parameters)
->values()
->all() ?: [new RFCValidation];

return (new EmailValidator)->isValid($value, new MultipleValidationWithAnd($validations));
$emailValidator = Container::getInstance()->make(EmailValidator::class);

return $emailValidator->isValid($value, new MultipleValidationWithAnd($validations));
}

/**
Expand Down