[10.x] Support for phpredis 6.0.0 #48362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalHubatka
pushed a commit
to MichalHubatka/framework
that referenced
this pull request
Sep 13, 2023
taylorotwell
pushed a commit
that referenced
this pull request
Oct 3, 2023
Co-authored-by: Steff Missot <[email protected]>
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #48361
The PHPRedis library removed
RedisCluster::constants since 6.0.0. Released on pecl today 2023-09-11The author of PHPREDIS recommends not using the constants of
RedisClusteranymore but using the constants inRedisinstead here: phpredis/phpredis#2262 (comment):This PR changes the use of
RedisCluster::for constants toRedis::.This is backward compatible since the underlying values of these constants are the same, so it will still work for older phpredis versions