Skip to content

Conversation

@fuwasegu
Copy link
Contributor

@fuwasegu fuwasegu commented Jan 23, 2023

This PR is a redo of #45767

Reason for re-submitting PR

The previous PR was closed because it made too many breaking changes to the existing variation rules.
This PR is a new implementation of the validation rules, with no changes to the existing implementation.

@tpetry
Copy link
Contributor

tpetry commented Jan 23, 2023

Instead of creating new validation rules, it would be better to add an optional ascii option to the existing ones: alpha:ascii, alpha_dash:ascii, alpha_num:ascii

@fuwasegu
Copy link
Contributor Author

Thanks for your code review!
I refactored so.

@taylorotwell taylorotwell merged commit 6edfb91 into laravel:9.x Jan 24, 2023
@taylorotwell
Copy link
Member

Great thought @tpetry

@fuwasegu fuwasegu deleted the feat/add-ascii-validation-rules branch January 25, 2023 05:58
taylorotwell added a commit to laravel/docs that referenced this pull request Jan 31, 2023
* [9.x] Follow laravel/framework#45769 changes

* Correct the definite articles

* Avoid ambiguous explanations

* Warning about Unicode dashes and underscores

* Link to unicode.org

* Update validation.md

---------

Co-authored-by: Taylor Otwell <[email protected]>
salehhashemi1992 pushed a commit to salehhashemi1992/docs that referenced this pull request Feb 8, 2023
* [9.x] Follow laravel/framework#45769 changes

* Correct the definite articles

* Avoid ambiguous explanations

* Warning about Unicode dashes and underscores

* Link to unicode.org

* Update validation.md

---------

Co-authored-by: Taylor Otwell <[email protected]>
@fuwasegu fuwasegu changed the title [9.x] Add validation rules: ascii_alpha, ascii_alpha_num, ascii_alpha_dash [9.x] Add validation rule options: alpha:ascii, alpha_num:ascii, alpha_dash:ascii May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants