[8.x] Make BuildsQueries::tap consistent with other versions of tap #42775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The previous PR targeted 9.x (unreleased at the time) because it was considered a breaking change for 8.x: #36217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned on #38343 and #38353.
This PR makes
BuildsQueries::tap()consistent withEnumeratesValues::tap()andtap(), meaning it will always return$thisafter executing the given callback. This change should not be breaking unless the developer was relying on undocumented behaviour (prior to #38353).This was merged in 9.x with #38359 PR but still remains in 8.x.