Skip to content

[9.x] Improve Unicode support on Str::squish() #41877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

[9.x] Improve Unicode support on Str::squish() #41877

merged 1 commit into from
Apr 7, 2022

Conversation

@rodrigopedra
Copy link
Contributor

@rodrigopedra rodrigopedra commented Apr 7, 2022

Similar to what was done in PR #40600 this PR:

  • Improves Unicode support on the newly added Str::squish() and its Stringable counterpart.
  • Adds tests from similar to the TrimStrings ones that would fail if without this PR

@taylorotwell taylorotwell merged commit 644c9d8 into laravel:9.x Apr 7, 2022
@nshiro nshiro mentioned this pull request Apr 14, 2022
Merged
@rodrigopedra rodrigopedra mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodrigopedra @taylorotwell