[9.x] Improves ResetPassword Notification docblock
#41529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
changed the title
ResetPassword Notification docblock
Jubeki
reviewed
Mar 17, 2022
| * The callback that should be used to build the mail message. | ||
| * | ||
| * @var \Closure|null | ||
| * @var (\Closure(mixed, string): \Illuminate\Notifications\Messages\MailMessage)|null |
Contributor
There was a problem hiding this comment.
It should also be possible to return a Mailable (I have never tried that).
Suggested change
| * @var (\Closure(mixed, string): \Illuminate\Notifications\Messages\MailMessage)|null | |
| * @var (\Closure(mixed, string): (\Illuminate\Notifications\Messages\MailMessage|\Illuminate\Mail\Mailable))|null |
Member
Author
There was a problem hiding this comment.
The usage class doesn't return what you suggesting. Maybe create different PR. I'm not adding something I can't confirm right now :-)
Co-authored-by: Julius Kiekbusch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mior Muhammad Zaki [email protected]