[9.x] Report file system exceptions #41279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jubeki
reviewed
Mar 1, 2022
Contributor
Jubeki
left a comment
Jubeki
left a comment
There was a problem hiding this comment.
You forgot lots of Semicolons.
I also think it is a good idea to at least report the errors.
Member
|
We cannot use a global helper in this class. You'll need to set the logger onto the class with a setter method and add a new config option that by default disables it. Then people can opt-into this. Please resubmit with these changes and make sure tests are passing. Thanks |
Contributor
Author
|
driesvints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@taylorotwell
This is an attempt to fix issue #41269
Suppressing all those file system exceptions was a bad decision made in PR #33612
Imaging your server's hard disk runs out of space or AWS S3 service went down, you will never gets notified about it and your customers will keep complaining about their missing uploaded files. I have spent hours already to figure out why my S3 uploads are not working.
This PR reports those errors so at-least the developer can look into logs and see what went wrong.
Willing to see feedback form the community on this solution. :)