[10.x] Improves Support\Collection reduce method type definition
#40813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdalcin
changed the title
Support\Collection reduce method type definition
|
Sorry if this isn't the right place to ask. I noticed this was merged into master, was this not a candidate for inclusion in the latest 9.x release? |
Member
|
@fdalcin it seems you indeed sent this to master instead of 9.x. Can you send this in to 9.x as well? |
driesvints
changed the title
Support\Collection reduce method type definitionSupport\Collection reduce method type definition
Contributor
Author
|
Hi, yes I can make a new PR sending this to 9.x. Thought I've done that, sorry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the improvements made by @nunomaduro on #38538, this pull request updates the type definition of
reduceandreduceWithKeysmethods to consider the$callbackkey parameter.Whenever the reduce callback expects the third parameter static analysis fail because the type is not defined which produces the following error.
