[9.x] Fixes Command::setHidden()
#40415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not entirely sure why I removed it in that PR. I thought there was a good reason for. |
Contributor
|
Thanks for adding this back Nuno. 👍🏻 |
Member
|
@driesvints I think we thought it was a no-op because the code looks the exact same as the parent class. But apparently it's not.😅 |
Member
|
hmm yeah that could indeed be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
Command::setHidden()method that was not actually hidden the command from thelistcommand.This regression was introduced on the #37941 pull request, and I've added a few tests to ensure this don't happen in the future.