Skip to content

Conversation

@selcukcukur
Copy link
Contributor

No description provided.

@dinhquochan
Copy link
Contributor

👎 this PR because Laravel 8.x required 7.3 that version does not have str_contains() function.

@selcukcukur
Copy link
Contributor Author

👎 this PR because Laravel 8.x required 7.3 that version does not have str_contains() function.

It can be used with the symfony/polyfill-php80 package. The str_contains method on php 7.x.

@selcukcukur selcukcukur changed the title [9.x & 8.x] Used str_contains instead of strpos. [9.x] Used str_contains instead of strpos. Dec 30, 2021
@GrahamCampbell
Copy link
Collaborator

This PR is not for Laravel 8. It's for Laravel 9, which is PHP 8.0.2+ only.

@dammy001
Copy link
Contributor

Exactly @GrahamCampbell

@taylorotwell taylorotwell merged commit 2beec5d into laravel:master Dec 30, 2021
@GrahamCampbell GrahamCampbell changed the title [9.x] Used str_contains instead of strpos. [9.x] Use str_contains instead of strpos Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants