[9.x] Skip unnecessary check before calling openssl_encrypt
#40108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krisell
changed the title
Krisell
changed the title
openssl_encrypt
taylorotwell
pushed a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP
7.4(before7.4.13)openssl_encryptemitted a warning when the$tagparameter was passed and the chosen cipher was not an AEAD cipher (AEAD ciphers set$tagby reference, other ciphers do not use this at all).Since
7.4.13and8.0.0this has been resolved and$tagis simply ignored, even if passed. This PR simplifies the code by removing the now unnecessary (but previously necessary) check.Here's the PHP fix
php/php-src@6c6a58e
And the PHP documentation for
openssl_encrypthttps://www.php.net/manual/en/function.openssl-encrypt.php