[8.x] Test the model:prune command pruning soft deleted models
#40023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Dec 14, 2021
driesvints
reviewed
Dec 14, 2021
derekmd
force-pushed
the
model-prune-soft-deleted-tests
branch
from
4e8b3e7 to
6fcdc97
Compare
Adding the --pretend option introduced a bug on soft-deleted models because there wasn't any test coverage. Ensure yesterday's bug fix isn't mistakenly changed in the future.
derekmd
force-pushed
the
model-prune-soft-deleted-tests
branch
from
6fcdc97 to
7c0a5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #39991
Test the command
model:prune(#37889) and its--pretendoption (#38945) on soft-deleted models which currently lack test coverage.