[9.x] Fix session retrieval from HTTP request #39830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to circumvent the changes Symfony did in v6 for type-hinting their
getSessionmethod. I already had to remove the method in the Symfony v6 PR I made earlier:https://github.com/laravel/framework/pull/38376/files#diff-4a2dd251f1519763d08bb47f9ae2e9029687a3208542d09e317166b89f57a7a7L491-L500
The reason why is that our own session store doesn't implements Symfony's
SessionInterfaceso we can't return like that anymore. We can safely call->sessioninstead because we're checking if the object is a Laravel HTTP Request class with theselftype-hint.This also solves the failing issues with Laravel 9 support in Fortify.