Update symfony mailer docblocks #38773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
Member
|
Thanks @Jubeki |
driesvints
pushed a commit
that referenced
this pull request
Sep 12, 2021
* Update docblocks from Swift Mailer to Symfony Mailer * Make TransportInterface more specific
taylorotwell
added a commit
that referenced
this pull request
Sep 14, 2021
* Implement Symfony Mailer * Apply fixes from StyleCI * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <[email protected]> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <[email protected]> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <[email protected]> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <[email protected]> * Update src/Illuminate/Mail/Message.php Co-authored-by: michael-rubel <[email protected]> * Update Array and Log transports * Apply fixes from StyleCI * Fix interface implementation * Update Mailer * Apply fixes from StyleCI * Rename * Remove method * Fix tests * Apply fixes from StyleCI * Work on Mailer tests * type-hint * Fix Mailer tests * Fix more tests * Apply fixes from StyleCI * Migrate Mailgun transport * Migrate Postmark transport * Replace SesTransport * Remove transports from dev dependencies * Allow setting options on esmtp transport * Fix Postmark transport * Fix embedding files * Clarify API transports * Apply fixes from StyleCI * Fix SES transport setup * Add MessageStreamId to Postmark Transport again (#38748) * Update symfony mailer docblocks (#38773) * Update docblocks from Swift Mailer to Symfony Mailer * Make TransportInterface more specific * Add Session Token to SES Transport (#38797) * Update src/Illuminate/Mail/Transport/ArrayTransport.php Co-authored-by: Julius Kiekbusch <[email protected]> * fix docblock * Add Wrapper for Symfony SentMessage (#38803) * Create SentMessage wrapper for Symfony's SentMessage * Wrap Symfony SentMessage * Update Docblocks to Illuminate\Mail\SentMessage * Fix sendMailable * Update SentMessage.php Co-authored-by: Dries Vints <[email protected]> Co-authored-by: Taylor Otwell <[email protected]> Co-authored-by: michael-rubel <[email protected]> Co-authored-by: Julius Kiekbusch <[email protected]> Co-authored-by: Taylor Otwell <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some old references to Swift_Mailer and replaces it with the Symfony Mailer equivalent.
Even though the Symfony's TransportFactories annotate TransportInterface as the return type, Some of Laravels docblocks have a specific return type annotated.
Example:
EsmtpTransportFactoryreturns an Object ofTransportInterfacebut in the Laravel DocBlocks the real class will be annotated, which is hereEsmtpTransportTherefor all
@returnannotations have the most specific class.