[8.x] Adds dynamic properties to AnonymousNotifiable

[DarkGhostHunter]

What?

Allows using dynamic properties like Eloquent Models to the AnonymousNotifiable (on demand notifications).

use Illuminate\Support\Facades\Notification;
use App\Notifications\GuitarShipped;

Notification::route('mail', '[email protected]')
    ->with(['name' => 'John', 'instrument' => 'guitar'])
    ->notify(new GuitarShipped('JP45'));

This solves the problem when a notification expects data from the notifiable, as the AnonymousNotifiable doesn't support gracefully chaining properties, as it difficult to manually set each of them. Worse case scenario: making another notification.

This way is totally safe to get injected data from the notifiable.

public function toMail($notifiable)
{
    return (new MailMessage)->subject("Hey $notifiable->name, your guitar is on route!");
}

The with() method supports Arrayable objects, so you can use a whole Model if you feel lazy.

use Illuminate\Support\Facades\Notification;
use App\Notifications\GuitarShipped;
use App\Models\Client;

$client = Client::find(477);

Notification::route('mail', '[email protected]')
    ->with($client) // I would used `$client->only('name', 'instrument'), but you do you.
    ->notify(new GuitarShipped('JP45'));

How?

I just slapped the Fluent helper into the AnonymousNotifiable and added the with() method to merge multiple attributes in one go.

BC?

Please...

Notes

1. The Notifications package requires the Support package, so there is no sin to use duck-tape Fluent in my opinion.
2. I didn't set with() into the Facade, so it still forces the developer to route first and merge properties later.
3. The other alternative I do is to clone the Model into the Notification, but feels very hacky to me.

[BrandonSurowiec]

One consideration. Fluent allows non-existent methods to add an attribute. Previously, non-existent methods would throw an error.

Notification::route('mail', '[email protected]')
    ->name('Ludwig van Beethoven')
    ->instrument('Piano')
    ->notify(new GuitarShipped('JP45'));

This behavior may or may not be desired. If it isn't then the __call method should be overridden in the AnonymousNotifiable class.

[DarkGhostHunter]

I consider that an improvement.

[derekmd]

1. With Fluent added, this typo expression would become a silent no-op that may only be detected by an integration test:

   Notification::route('mail', '[email protected]')
       ->rout('nexmo', '5555555555')
       ->local('not_locale')
       ->notif(new NotDeliveredNotification);

2. If $name, $instrument, or $client are required to build the notification, they can be passed into the GuitarShipped constructor with less message-passing magic.

[DarkGhostHunter]

1. With Fluent added, this typo expression would become a silent no-op that may only be detected by an integration test:

Well, that's a valid point. I'll disable the __call() by overriding it.

2. If $name, $instrument, or $client are required to build the notification, they can be passed into the GuitarShipped constructor with less message-passing magic.

When you use a notifiable Model you are still end up using message-passing magic. Using with() allows to rewrite the Notification to keep using the Notifiable data.

[driesvints]

We're reverting this: #38651. I agree with @derekmd that a better way would be to pass the arguments to the notification constructor.