Skip to content

[9.x] Update firstOrFail logic #38470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

[9.x] Update firstOrFail logic #38470

merged 1 commit into from
Aug 20, 2021

Conversation

@chu121su12
Copy link
Contributor

@chu121su12 chu121su12 commented Aug 20, 2021

PR #38420 Introduces firstOrFail on collection classes, which on version 8.x uses when for filtering. The logic was adjusted to use unless in #37667 and this PR align the code to also use unless.

@driesvints driesvints merged commit f409e04 into laravel:master Aug 20, 2021
@driesvints
Copy link
Member

driesvints commented Aug 20, 2021

Thanks!

@chu121su12 chu121su12 deleted the update-logic branch August 20, 2021 12:13
@felixdorn felixdorn mentioned this pull request Sep 19, 2021
Closed
@otilor otilor mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chu121su12 @driesvints