[8.x] Convert non-existant namespace #38449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
X-Coder264
added a commit
to petersons/d2l-client
that referenced
this pull request
Oct 21, 2021
- 8.56 is the min version due to laravel/framework#38449
X-Coder264
added a commit
to petersons/d2l-client
that referenced
this pull request
Oct 21, 2021
- 8.56 is the min version due to laravel/framework#38449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently #37034 introduced a new non-existent
Illuminate\Collectionsnamespace. I'm not entirely sure how the current code can even work given the fact that the namespace isn't auto-loaded by Composer.Changing this now could be considered a breaking change but I think we should treat this as a bug fix instead. Alternatively this can be sent to master but then 8.x would be the only version to have an
Illuminate\Collectionsnamespace.