Skip to content

[9.x] Dont recompile view if lastModified is same as cache file #38415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[9.x] Dont recompile view if lastModified is same as cache file #38415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f83e73
Update Compiler.php
Jimbolino Aug 17, 2021
9ad9e21
Make Application@handle() meet Symfony 6's updated interface (#38413)
derekmd Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Illuminate/Foundation/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
use Illuminate\Support\Str;
use RuntimeException;
use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\HttpKernel\HttpKernelInterface;
Expand Down Expand Up @@ -959,7 +960,7 @@ protected function fireAppCallbacks(array $callbacks)
/**
* {@inheritdoc}
*/
public function handle(SymfonyRequest $request, int $type = self::MASTER_REQUEST, bool $catch = true)
public function handle(SymfonyRequest $request, int $type = self::MAIN_REQUEST, bool $catch = true): SymfonyResponse
{
return $this[HttpKernelContract::class]->handle(Request::createFromBase($request));
}
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/View/Compilers/Compiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function isExpired($path)
return true;
}

return $this->files->lastModified($path) >=
return $this->files->lastModified($path) >
$this->files->lastModified($compiled);
}

Expand Down