Skip to content

Conversation

@derekmd
Copy link
Contributor

@derekmd derekmd commented Aug 16, 2021

More Symfony 6 type-checking whack-a-mole.

#38376 passed green but Symfony's 6.x dev branch introduced another breaking change within 3 hours.

HttpKernelInterface::MASTER_REQUEST has also been deprecated for HttpKernelInterface::MAIN_REQUEST.

Add return type. This is a great use of our time.
@derekmd derekmd marked this pull request as ready for review August 16, 2021 22:30
@driesvints
Copy link
Member

Thanks @derekmd. Saves me the time for doing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants